Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci skip] Document Rails' shifted semver. #15417

Merged
merged 1 commit into from May 30, 2014
Merged

[ci skip] Document Rails' shifted semver. #15417

merged 1 commit into from May 30, 2014

Conversation

JuanitoFatas
Copy link
Contributor

Since Rails use shifted semver scheme, it's good to document it.

References: #9979 and #6610.

Please review the content. Thanks.

**Minor `y`**

New features, may contain API changes (Serve as major versions of Semver).
Breaking Changes are paired with deprecation notices in a patch version of the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking changes*

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

zzak pushed a commit that referenced this pull request May 30, 2014
[ci skip] Document Rails' shifted semver.
@zzak zzak merged commit 6963e33 into rails:master May 30, 2014
@JuanitoFatas JuanitoFatas deleted the doc/semver-of-rails branch May 30, 2014 03:46
@JuanitoFatas
Copy link
Contributor Author

Thanks for excellent review. 💛 💜 ❤️

@rafaelfranca
Copy link
Member

The content is wrong. But I can fix later

@rafaelfranca
Copy link
Member

s/is wrong/has some errors/

@zzak
Copy link
Member

zzak commented May 30, 2014

@rafaelfranca ugh, what errors? i just went and backported it

@rafaelfranca
Copy link
Member

The definition of each level is not paired of how our version schema works
now.

Rafael Mendonça França
http://twitter.com/rafaelfranca
https://github.com/rafaelfranca

On Fri, May 30, 2014 at 12:49 AM, Zachary Scott notifications@github.com
wrote:

@rafaelfranca https://github.com/rafaelfranca ugh, what errors? i just
went and backported it


Reply to this email directly or view it on GitHub
#15417 (comment).

@zzak
Copy link
Member

zzak commented May 30, 2014

@rafaelfranca could you elaborate? the content we used was almost exactly as you described it here

@rafaelfranca
Copy link
Member

Yup, pretty much. The only think that is not correct is how deprecations are made.

@rafaelfranca
Copy link
Member

Fixed at c36c7fc

@zzak
Copy link
Member

zzak commented May 30, 2014

@rafaelfranca thanks! <3

@JuanitoFatas
Copy link
Contributor Author

Thanks! 😓

@rafaelfranca
Copy link
Member

You are welcome, and it is fine you don't know it. After all this was an information only know by the Rails Core members. Thank you for making this public.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants