Prevent time field converting zones in changes 'was' #15632
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When changing "Time" attributes the old '_was' value (e.g. bonus_time_was) will be converted based on zone. However, in all other cases "Time" attributes do not convert zones.
The expected behaviour is to NOT convert zones due to variations across dates, even within a single zone -- see more discussion here: #3145 (comment)
Original commit added here: 36129f2
Then later removed in commit slated for rails 4.(?) cb400b0
I've made the PR to rails 3-2-stable since rails 4+ seems to have rearranged the dirty.rb file considerably.