Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more exceptions on pluralization for -fe/-ve endings #15740

Closed
wants to merge 1 commit into from
Closed

Add more exceptions on pluralization for -fe/-ve endings #15740

wants to merge 1 commit into from

Conversation

phstc
Copy link

@phstc phstc commented Jun 15, 2014

I'm not sure what's the best way to deal with these pluralization exceptions - if adding in the Rails core or only in the applications, but currently without this commit 'olive'.pluralize => 'olifes' instead of 'olives'.

I tried to update the plural/singular regular expressions that match 'olive', but I got some conflicts with 'knife', 'wife', 'life' etc.

  • wi_fe_ => wi_ves_
  • sa_fe_ => sa_fes_

  • wi_ves_ => wi_fe_
  • oli_ves_ => oli_ve_

@matthewd
Copy link
Member

Thanks, but inflections are frozen, to avoid breaking existing applications; please just add what you need in your application. We added a comment at the top of the file a couple of months ago (07c7024), but it looks like your branch predates it.

@matthewd matthewd closed this Jun 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants