Deprecate automatic counter caches on has_many :through #15742
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This functionality has been broken for a long time. We can only set it one way. It does not update when the intermediate records are destroyed. It is entirely duplicating the behavior of a counter_cache on the through record. It acts inconsistently with manual counter caches. It was proposed that we should deprecate this behavior a while back (rails#3903 (comment)). I think the time has come to do so.
|
Does this negatively affect habtm? |
|
HABTM doesn't support counter caches, and this weird automatic detection is undocumented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality has been broken for a long time. We can only set it
one way. It does not update when the intermediate records are destroyed.
It is entirely duplicating the behavior of a counter_cache on the through
record. It acts inconsistently with manual counter caches.
It was proposed that we should deprecate this behavior a while back
(#3903 (comment)). I
think the time has come to do so.
Fixes #3903