Fix template assertion when opening a session. #16272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @_partials.clear | ||
| @_templates.clear | ||
| @_layouts.clear | ||
| @_files.clear |
There was a problem hiding this comment.
Clearing all the Hash instead of creating new ones since the subscribers are registered with the Hash objects created during setup. The previous change introduced a regression because we are actually creating new Hash objects in the duplicated context which are not the same as those registered with the subscribers.
|
@tgxworld can we add those ivars into an array ant iterate over that? This way both places will stay in sync. |
| @@ -12,8 +12,13 @@ module TemplateAssertions | |||
| teardown :teardown_subscriptions | |||
| end | |||
|
|
|||
| RENDER_TEMPLATE_INSTANCE_VARIABLES = %w{partials templates layouts files}.freeze | |||
There was a problem hiding this comment.
@senny Instead of creating a new instance variable for the array, I decided to use a constant instead. Any thoughts?
|
@senny Updated 😄 |
matthewd
added a commit
that referenced
this pull request
Jul 25, 2014
…pening_a_session Fix template assertion when opening a session.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #16234 (comment)
@senny @rubys