Fix counter_cache for polymorphic associations #16445
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 9, 2014
| @@ -1,3 +1,10 @@ | |||
| * Fix counter_cache to work with polymorphic relations. This appears to have | |||
There was a problem hiding this comment.
'This appears to have been broken for a while.' is not necessary in the CHANGELOG.
There was a problem hiding this comment.
Removed it from there (and also rebased).
Also removes a false positive test that depends on the fixed bug: At this time, counter_cache does not work with polymorphic relationships (which is a bug). The test was added to make sure that no StaleObjectError is raised when the car is destroyed. No such error is currently raised because the lock version is not incremented by appending a wheel to the car. Furthermore, `assert_difference` succeeds because `car.wheels.count` does not check the counter cache, but the collection size. The test will fail if it is replaced with `car.wheels_count || 0`.
sgrif
added a commit
that referenced
this pull request
Jul 19, 2015
Since the counter cache was properly being updated, the model became stale. Simply reloading the model before attempting to destroy is sufficient for this case. I believe this is enough of an edge case to be a valid change to the tests, even though it represents a potential breaking change.
sgrif
added a commit
that referenced
this pull request
Jul 19, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16407.
ActiveRecord::Association::Builder::BelongsTo does not take into account polymorphic relationships. This change takes care of that.
Unfortunately, the fix broke a test. Fortunately, the test depended on this bug being present. I've removed it and detailed the reasons in the commit message. I'm copying it here for completeness' sake:
/cc @senny