Support unscoping default_scope in eager_loaded associations #16531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 17, 2014
|
@rafaelfranca or @jonleighton is there anything else I should add? |
cwjenkins
force-pushed
the
allow-unscoping-default-scope-on-associations
branch
3 times, most recently
from
fd4fab3
to
db08e83
Compare
For eager_loaded joins move the default scope to the front of the scope chain to be merged first. For preloading check values for unscope and add to the scope being built unscope_values. On preload, no need to change merge sequence given default scope is merged first.
cwjenkins
force-pushed
the
allow-unscoping-default-scope-on-associations
branch
from
db08e83
to
5884821
Compare
|
What happens if |
grosser
added a commit
to zendesk/predictive_load
that referenced
this pull request
Sep 2, 2015
unscoped { includes } is broken in rails 4+
so we try to avoid this bug by disabling eager loading -> triggering less includes
maybe coming fix: rails/rails#16531
grosser
added a commit
to zendesk/predictive_load
that referenced
this pull request
Sep 2, 2015
unscoped { includes } is broken in rails 4+
so we try to avoid this bug by disabling eager loading -> triggering less includes
maybe coming fix: rails/rails#16531
grosser
added a commit
to zendesk/predictive_load
that referenced
this pull request
Sep 2, 2015
unscoped { includes } is broken in rails 4+
so we try to avoid this bug by disabling eager loading -> triggering less includes
maybe coming fix: rails/rails#16531
grosser
added a commit
to zendesk/predictive_load
that referenced
this pull request
Sep 2, 2015
unscoped { includes } is broken in rails 4+
so we try to avoid this bug by disabling eager loading -> triggering less includes
maybe coming fix: rails/rails#16531
grosser
added a commit
to zendesk/predictive_load
that referenced
this pull request
Sep 2, 2015
unscoped { includes } is broken in rails 4+
so we try to avoid this bug by disabling eager loading -> triggering less includes
maybe coming fix: rails/rails#16531
|
Any chance of this being backported to Rails 4.2 as well? |
|
Is this fixed in rails 5? |
|
This will fix #20679 for joins/eager_load and also covers preload/includes(without references). While we can unscope default_scope in joins/eager_load by #18109, somehow the counterpart for preload/includes is rejected in #25187. So this PR would be the only way to unscope default_scipe in preload/includes. @cwjenkins Could you rebase this against master? |
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
Jun 28, 2017
Unscoping `default_scope` in associations has already supported (rails#17360 for preloading, c9cf8b8 for eager loading). Fixes rails#20679. Closes rails#16531.
kamipo
added a commit
that referenced
this pull request
Sep 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For eager_loaded joins move the default scope to the front of the scope chain to be merged first.
For preloading check values for unscope and add to the scope being built unscope_values.
On preload, no need to change merge sequence given default scope is merged first.