Added ternary operation and more readable code. #1659
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| dom_class(record, prefix || NEW) | ||
| end | ||
| record_id = record_key_for_dom_id(record) | ||
| record_id ? "#{dom_class(record, prefix)}#{JOIN}#{record_id}" : dom_class(record, prefix || NEW) |
There was a problem hiding this comment.
My 2 cents: This is not much readable compared to original.
|
Ternary conditions instead of "normal" ones don't make things more readable. Neither do parenthesis. |
|
Whether these changes make things more readable is a matter of subjective opinion, however they do pollute the timeline and reduce the effectiveness of tools like |
jake3030
pushed a commit
to jake3030/rails
that referenced
this pull request
Jun 28, 2011
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
jake3030
pushed a commit
to jake3030/rails
that referenced
this pull request
Jun 28, 2011
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.