[ActiveJob] Autoload adapters #16700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -17,7 +17,6 @@ def queue_adapter=(name_or_adapter) | |||
|
|
|||
| private | |||
| def load_adapter(name) | |||
| require "active_job/queue_adapters/#{name}_adapter" | |||
There was a problem hiding this comment.
I believe we don't need to use autoload for this. It will be lazy loaded anyway.
|
Autoloading it's nicer than require. Edited: removed this nonsense "Also adapters can be added from gems without placing them in |
But it brings problem with threaded environments.
Yes @seuros already explained me at Campfire. Seems good 👍 |
rafaelfranca
added a commit
that referenced
this pull request
Aug 26, 2014
[ActiveJob] Autoload adapters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That will fix a bug when a backend don't require the adapter first
fixes: sidekiq/sidekiq#1912
That will also autoload the TestAdapter when required instead of always requiring it. (WIP)
cc @mperham @dhh @rafaelfranca