Add support for multiple preview_path

[camelmasa]

Hi guys.

I'd like to add support for multiple preview_path of ActionMailer. (It could configure only one directory path now.)

Because I think I'd like to configure it in Rails Engine.

For example.

initializer "spree.core.mailers_previews" do |app|
  app.config.action_mailer.preview_path << File.join(root, "test", "mailers", "previews")
end

[seuros]

cc @rafaelfranca @matthewd

[PapePathe]

+1

[rafaelfranca]

Although I agree with the change I don't like the idea of setting an array to a configuration with singular name. Also I think we should use the Rails::Paths class to implement this. https://github.com/rails/rails/blob/8683396dd8c31c70ba9332586ee05889305fdde6/railties/lib/rails/engine.rb#L70-109

[camelmasa]

@rafaelfranca Thanks for review. I'll update it.

[seuros]

any update @camelmasa ?

[camelmasa]

@seuros I created some commits but there are some problems...

[camelmasa]

@seuros Thanks a lot for review.

I thought other approach.

• don't use ActionMailer::Base.preview_paths
• Remove ActionMailer::Base.preview_path
• use Rails::Paths

For example commit.
camelmasa@fecd129

I think this way is more simple... What do you think about this ?

[attilahorvath]

Hey @camelmasa,

We would like to extend the functionality of this config option the same way you did.

Do you think it would be possible to apply your changes on edge Rails and see if the issues can be fixed?

[rails-bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.