move cache_digests rake methods into their own namespace #17069
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we found a bug when running this task in our CI system:
actionview/lib/action_view/tasks/dependencies.rake
defines two methods that end up in the global namespace, and these shadowed an attribute with the same name (template_name
) in a FactoryGirl factory:which resulted in this error:
to resolve i just stuck these in their own namespace but you might consider having a namespace just for rake first (RakeHelpers or something) and then putting this class inside that one. i'm guessing this isn't the only place where the global namespace is being polluted from a rake task.