Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concurrent load interlock (rm Rack::Lock) #17102

Merged
merged 4 commits into from Jul 10, 2015
Merged

Concurrent load interlock (rm Rack::Lock) #17102

merged 4 commits into from Jul 10, 2015
+315 −53

Commits on Jul 8, 2015

  1. Soften the lock requirements when eager_load is disabled 

    We don't need to fully disable concurrent requests: just ensure that
loads are performed in isolation.
    @matthewd
    matthewd committed Jul 8, 2015
    Copy the full SHA
    c37d47e View commit details
    Browse the repository at this point in the history

  2. Rely on the load interlock for non-caching reloads, too

    @matthewd
    matthewd committed Jul 8, 2015
    Copy the full SHA
    383fed5 View commit details
    Browse the repository at this point in the history

  3. Fix the Interlock middleware 

    We can't actually lean on Rack::Lock's implementation, so we'll just
copy it instead. It's simple enough that that's not too troubling.
    @matthewd
    matthewd committed Jul 8, 2015
    Copy the full SHA
    48a735a View commit details
    Browse the repository at this point in the history

  4. Document ShareLock and the Interlock

    @matthewd
    matthewd committed Jul 8, 2015
    Copy the full SHA
    0b93c48 View commit details
    Browse the repository at this point in the history