Treat strings greater than int max value as non-numeric #17459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgrif
force-pushed
the
sg-find-by-large-numbers
branch
from
dd0f7e0
to
8fae9df
Compare
Sufficiently large integers cause `find` and `find_by` to raise `StatementInvalid` instead of `RecordNotFound` or just returning `nil`. Given that we can't cast to `nil` for `Integer` like we would with junk data for other types, we raise a `RangeError` instead, and rescue in places where it would be highly unexpected to get an exception from casting. Fixes rails#17380
sgrif
force-pushed
the
sg-find-by-large-numbers
branch
from
8fae9df
to
e62fff4
Compare
sgrif
added a commit
that referenced
this pull request
Oct 31, 2014
Treat strings greater than int max value as out of range
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
Sep 6, 2016
Raising `RangeError` was introduced in order to ease to handle out of range numbers for `find` and `find_by` in postgresql adapter with prepared statements since rails#17459. At that time, `Type::Integer` assumed implicit default byte size is 4 bytes due to `extract_limit` in postgresql adapter did not extract an integer byte size correctly. That assumption is harmful for other adapters and caused rails#22594. In rails#26386, it is fixed to register integer types limit correctly. The handling whether out of range or not is only needed with explicit `limit`, and `Type::BigInteger` is no longer needed. Fixes rails#22594.
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
Aug 20, 2017
Raising `RangeError` was introduced in order to ease to handle out of range numbers for `find` and `find_by` in postgresql adapter with prepared statements since rails#17459. At that time, `Type::Integer` assumed implicit default byte size is 4 bytes due to `extract_limit` in postgresql adapter did not extract an integer byte size correctly. That assumption is harmful for other adapters and caused rails#22594. In rails#26386, it is fixed to register integer types limit correctly. The handling whether out of range or not is only needed with explicit `limit`, and `Type::BigInteger` is no longer needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sufficiently large integers cause
findandfind_byto raiseStatementInvalidinstead ofRecordNotFoundor just returningnil.Normally, we cast junk input to
nil, but we can't do so here, as itcan cause MySQL to blow up. 0 is what you would get for any other
non-numeric string, so we use the same value here.
Fixes #17380