allow reseting of request variants #18052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation of `variants=` don't allow a resetting to nil, wich is the default value. This results in the following code smell: ```ruby case request.user_agent when /iPhone/ request.variants = :phone when /iPad/ request.variants = :ipad end ``` With the ability to reset variants to nil, it could be: ```ruby request.variants = case request.user_agent when /iPhone/ :phone when /iPad/ :ipad end ```
rafaelfranca
added a commit
that referenced
this pull request
Dec 16, 2014
allow reseting of request variants
rafaelfranca
added a commit
that referenced
this pull request
Dec 17, 2014
allow reseting of request variants
rafaelfranca
added a commit
that referenced
this pull request
Dec 17, 2014
allow reseting of request variants
|
@timoschilling backported to 4-2-stable, 4-2-0 and 4-1-stable |
rafaelfranca
added a commit
that referenced
this pull request
Dec 17, 2014
allow reseting of request variants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
variants=don't allow a resetting to nil, wich is the default value.This results in the following code smell:
With the ability to reset variants to nil, it could be: