More jruby gem for database fixes #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenderlove
added a commit
that referenced
this pull request
Jun 21, 2011
…fixes More jruby gem for database fixes
|
This is fantastic. |
|
+1 |
|
I did not know I could do 🔥! |
|
That's amazing. |
|
Great! |
|
Tests added here :-) |
| @@ -9,7 +9,7 @@ | |||
| # And be sure to use new-style password hashing: | |||
| # http://dev.mysql.com/doc/refman/5.0/en/old-client.html | |||
| development: | |||
| adapter: jdbcmysql | |||
| adapter: mysql | |||
There was a problem hiding this comment.
I have modified database.rake before to work db:create and other database operations with "jdbcmysql" and other jdbc* stuff. That time i was not sure that only "mysql" will also work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes update the JRuby/JDBC database support to be a little friendlier.
rails new appwith no arguments and get a proper JRuby/sqlite3-based Rails app.rails new app -d sqlite3andrails new app -d jdbcsqlite3will do the same thing.rails new app -d jdbctemplate for all other databases.