New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove *_filter #18410

Merged
merged 1 commit into from Jan 8, 2015

Conversation

Projects
None yet
2 participants
@seuros
Member

seuros commented Jan 8, 2015

No description provided.

@rafaelfranca

This comment has been minimized.

Show comment
Hide comment
@rafaelfranca

rafaelfranca Jan 8, 2015

Member

Keep the implementation but raise a NoMethodError pointing to the right method. This was never deprecated, so it is better to at least point user to the new implementation.

Member

rafaelfranca commented Jan 8, 2015

Keep the implementation but raise a NoMethodError pointing to the right method. This was never deprecated, so it is better to at least point user to the new implementation.

@rafaelfranca

This comment has been minimized.

Show comment
Hide comment
@rafaelfranca

rafaelfranca Jan 8, 2015

Member

Or you could just revert 489a8f2

Member

rafaelfranca commented Jan 8, 2015

Or you could just revert 489a8f2

@seuros

This comment has been minimized.

Show comment
Hide comment
@seuros

seuros Jan 8, 2015

Member

Done.

Member

seuros commented Jan 8, 2015

Done.

rafaelfranca added a commit that referenced this pull request Jan 8, 2015

@rafaelfranca rafaelfranca merged commit a74041d into rails:master Jan 8, 2015

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details

@seuros seuros deleted the seuros:ripfilter branch Jan 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment