Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove *_filter #18410

Merged
merged 1 commit into from Jan 8, 2015
Merged

remove *_filter #18410

merged 1 commit into from Jan 8, 2015

Conversation

@seuros
Copy link
Member

@seuros seuros commented Jan 8, 2015

No description provided.

@rafaelfranca
Copy link
Member

@rafaelfranca rafaelfranca commented Jan 8, 2015

Keep the implementation but raise a NoMethodError pointing to the right method. This was never deprecated, so it is better to at least point user to the new implementation.

@rafaelfranca
Copy link
Member

@rafaelfranca rafaelfranca commented Jan 8, 2015

Or you could just revert 489a8f2

@seuros seuros force-pushed the seuros:ripfilter branch to 7644a99 Jan 8, 2015
@seuros
Copy link
Member Author

@seuros seuros commented Jan 8, 2015

Done.

rafaelfranca added a commit that referenced this pull request Jan 8, 2015
remove *_filter
@rafaelfranca rafaelfranca merged commit a74041d into rails:master Jan 8, 2015
1 check was pending
1 check was pending
continuous-integration/travis-ci The Travis CI build is in progress
Details
@seuros seuros deleted the seuros:ripfilter branch Jan 13, 2016
falusi94 added a commit to kir-dev/pek-next that referenced this pull request Aug 26, 2019
falusi94 added a commit to kir-dev/pek-next that referenced this pull request Oct 29, 2019
falusi94 added a commit to kir-dev/pek-next that referenced this pull request Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.