Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

send_file should be able to guess default mime type from filename #1847

Closed
esad opened this issue Jun 24, 2011 · 2 comments
Closed

send_file should be able to guess default mime type from filename #1847

esad opened this issue Jun 24, 2011 · 2 comments

Comments

@esad
Copy link
Contributor

esad commented Jun 24, 2011

Currently, send_file will use application/octet-stream as mime type per default although a correct mime type can be inferred from the file extension most of the time
@anildigital
Copy link
Contributor

Patch is welcome.

@esad
Copy link
Contributor Author

esad commented Jun 28, 2011

I just made a pull request (#1875). Are pull requests preferred, or should I attach a patch?

josevalim added a commit that referenced this issue Jun 28, 2011
@josevalim
Merge pull request #1875 from esad/master
4f372cf 
Fixed issue #1847
jake3030 pushed a commit to jake3030/rails that referenced this issue Jun 28, 2011
@guillermo @dhh
Deprecated warnings for :skip_last_command and :connector of to_sente…
ff1afbd 
…nce [rails#1847 state:committed]

Signed-off-by: David Heinemeier Hansson <david@loudthinking.com>
@dependabot-preview dependabot-preview bot mentioned this issue May 10, 2019
Closed
@dependabot-preview dependabot-preview bot mentioned this issue Aug 11, 2019
Closed
@dependabot-preview dependabot-preview bot mentioned this issue Nov 4, 2019
Closed
@dependabot-preview dependabot-preview bot mentioned this issue Dec 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@anildigital @josevalim @esad