Fix before_commit when updating a record on the callback #19325
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -147,6 +151,8 @@ def initialize(connection) | |||
| end | |||
|
|
|||
| def begin_transaction(options = {}) | |||
| options[:run_callbacks] ||= !current_transaction.joinable? | |||
There was a problem hiding this comment.
this will allow anyone that creates a new transaction to force that transaction to run callbacks. I think this is a good feature to have. But I cannot think about use cases, so I am not sure if we should add it or not.. In any case, if we dont want that feature I can just remove the || from this line.
There was a problem hiding this comment.
-1 to expose it. This mutates options argument as well.
Would consider passing a separate keyword argument instead, e.g.:
RealTransaction.new(@connection, options, run_commit_callbacks: !current_transaction.joinable?)There was a problem hiding this comment.
yeah.. i was not sure about this API.
I like your suggestion, will do that.. thanks!
arthurnn
force-pushed
the
fix_before_commit_cb
branch
from
97b71d6
to
c2c9f37
Compare
|
merged via 0d76ab9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixing a bug, and refactoring the code a bit.
Bug:
before_commitwas called after the transaction was poped from the stack, that caused any update on that callback to not join that transaction.I fixed that bug in here, and cleaned up the code on
commit_transaction, so now, thecommit_recordsoradd_to_transactiondecision is on the transaction object, which is the one that holds the records anyways.I think this implementation is cleaner, so instead of we check the
joinableflag on the commit, we check when we create a new transaction.I would like to know what @jeremy things about this tho.
(#19324 is falling because of we need this fix for the
touchcalls)