Force ActionDispatch::Request#xhr? to return true or false #19424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ActionDispatch::Request#xhr?` comment lines say "Return true if ...", but in fact it returns 0 instead of `true`. This is because `String#=~` returns Fixnum or `nil`. I think it should always return `true` or `false` only, so I replaced it with `Regexp#===`.
|
Thanks, but 0 evaluates as true in Ruby and we're fine with that ❤️ |
|
@shunsukeaida Thanks! I haven't read them 😍 |
|
@kaspth OK, I see. Thanks for your quick response! 👍 |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ActionDispatch::Request#xhr?comment lines say "Return true if ...", but in fact it returns 0 instead oftrue. This is becauseString#=~returns Fixnum ornil. I think it should always returntrueorfalseonly, so I replaced it withRegexp#===.