Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent duplicating where clauses #19770

Merged
merged 1 commit into from
Aug 13, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions activerecord/lib/active_record/scoping/default.rb
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ def default_scope(scope = nil)
end

def build_default_scope(base_rel = relation) # :nodoc:
return if abstract_class?
if !Base.is_a?(method(:default_scope).owner)
# The user has defined their own default scope method, so call that
evaluate_default_scope { default_scope }
Expand Down
6 changes: 6 additions & 0 deletions activerecord/test/cases/scoping/default_scoping_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
require 'models/comment'
require 'models/developer'
require 'models/computer'
require 'models/vehicle'

class DefaultScopingTest < ActiveRecord::TestCase
fixtures :developers, :posts, :comments
Expand Down Expand Up @@ -441,4 +442,9 @@ def test_default_scope_is_threadsafe
assert_equal 1, scope.where_clause.ast.children.length
assert_equal Developer.where(name: "David"), scope
end

def test_with_abstract_class_where_clause_should_not_be_duplicated
scope = Bus.all
assert_equal scope.where_clause.ast.children.length, 1
end
end
7 changes: 7 additions & 0 deletions activerecord/test/models/vehicle.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
class Vehicle < ActiveRecord::Base
self.abstract_class = true
default_scope -> { where("tires_count IS NOT NULL") }
end

class Bus < Vehicle
end