[ci skip] Don’t encourage sudo gem install
#20128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think we are better off leaving `sudo` outside of the documented way of installing gems (`activerecord`, `actionpack`, …). We don’t want newbies to think that `sudo` is required or, even worse, than they actually have to type `[sudo] gem install`. In most scenarios, `sudo` is not needed to install gems, and people who do need it, probably already know about it. What do you think? 😁
|
(on a side note… do we still want to keep some README as rdoc and others as markdown?) |
rafaelfranca
added a commit
that referenced
this pull request
May 12, 2015
[ci skip] Don’t encourage `sudo gem install`
|
Active job README should be rdoc |
|
@rafaelfranca are you sure you don't mean that everything else should be markdown? 😔 |
|
Yes. The README are used to generate the rdoc documentation |
|
Yes, but sdoc now supports markdown: in fact you can see the result of ActiveJob’s README.md here: http://edgeapi.rubyonrails.org/files/activejob/README_md.html |
|
Ah, so lets as @fxn about that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we are better off leaving
sudooutside of the documented way of installing gems (activerecord,actionpack, …).We don’t want newbies to think that
sudois required or, even worse, than they actually have to type[sudo] gem install.In most scenarios,
sudois not needed to install gems, and people who do need it, probably already know about it.What do you think? 😁