Change regexp of RouteSet's conditions[:request_method]
#20787
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Make sense. Can we add a test case for this? |
|
This method was removed by 6c48d93. |
|
ref: 0b476de |
RFC2616 defines Request-Line which includes method token is separated by SP characters. So we should not match it with multiline anchors. cf: http://www.w3.org/Protocols/rfc2616/rfc2616-sec5.html#sec5.1
yui-knk
force-pushed
the
fix/request_method_regexp
branch
from
18d0abe
to
b8b745d
Compare
|
@arthurnn I rebased. And change |
|
Please DO NOT merge this, until #21849 is determined to be merged or not. |
|
Closing as #21849 has been merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC2616 defines Request-Line which includes method token
is separated by SP characters.
So we should not match it with multiline anchors.
cf: http://www.w3.org/Protocols/rfc2616/rfc2616-sec5.html#sec5.1