Removed mocha from ActionMailer #21306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -102,16 +102,21 @@ def welcome(hash={}) | |||
| end | |||
|
|
|||
| test "ActionMailer should be told when Mail gets delivered" do | |||
| DeliveryMailer.expects(:deliver_mail).once | |||
| DeliveryMailer.welcome.deliver_now | |||
| DeliveryMailer.delivery_method = :test | |||
There was a problem hiding this comment.
Shouldn't delivery method be test by default? I'd rather if we found a way not to set it.
There was a problem hiding this comment.
By default delivery_method is smtp, so it's trying to deliver email. I'm getting the following error because of it
MailDeliveryTest#test_ActionMailer_should_be_told_when_Mail_gets_delivered:
Errno::ECONNREFUSED: Connection refused - connect(2) for "localhost" port 25So either we have to set delivery_method :test or we have to stub any instance Mail::SMTP.
WDYT?
There was a problem hiding this comment.
I was worried that changing the delivery_method would spill over into other tests, but the setup and teardown makes sure to keep the old delivery method: https://github.com/rails/rails/pull/21306/files#diff-db5e616c1ed1b103bd61d787ad6cf567R100
So there's no problem.
kaspth
added a commit
that referenced
this pull request
Aug 20, 2015
Removed mocha from ActionMailer
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\cc @kaspth