Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rails/application: allow passing an env to config_for #22128

Merged
merged 1 commit into from Oct 30, 2015

Conversation

sirupsen
Copy link
Contributor

Would make it easier to write tests to sanity check configuration files for other environments.

@rafaelfranca @byroot

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @carlosantoniodasilva (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@byroot
Copy link
Member

byroot commented Oct 30, 2015

👍

@rafaelfranca
Copy link
Member

hmmmm, I has hoping to use the second argument as a default value when the config file is not found but I guess I can still use the block version for that. See https://groups.google.com/d/msg/rubyonrails-core/3kCxt2wr8XM/80K_54f8DAAJ.

@byroot
Copy link
Member

byroot commented Oct 30, 2015

Or maybe it could be a named argument?

@sirupsen
Copy link
Contributor Author

👍 to named argument if those are used in Rails core now.

@rafaelfranca
Copy link
Member

Yes, they are. :shipit:

@sirupsen
Copy link
Contributor Author

Updated to use a named argument

rafaelfranca added a commit that referenced this pull request Oct 30, 2015
rails/application: allow passing an env to config_for
@rafaelfranca rafaelfranca merged commit 35caf46 into rails:master Oct 30, 2015
@rafaelfranca
Copy link
Member

❤️ 💚 💙 💛 💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants