HSTS without IncludeSubdomains is often useless #22663
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Because if you forget to add Secure; to the session cookie, it will leak to http:// subdomain in some cases 2) Because http:// subdomain can Cookie Bomb/cookie force main domain or be used for phishing. That's why *by default* it must include subdomains as it's much more common scenario. Very few websites *intend* to leave their blog.app.com working over http:// while having everything else encrypted. Yes, many developers forget to add subdomains=true by default, believe me :)
|
r? @senny (@rails-bot has picked a reviewer for you, use r? to override) |
|
I tend to agree (but put a good warning somewhere in the docs). Without IncludeSubdomains it also does not save you from https://example.com -> http://www.example.com redirects. https://twitter.com/jgrahamc/status/677829158366543872 |
|
Agree, but it's a breaking change. Path forward:
|
|
@homakov are you working on Jeremy's suggestions? Otherwise I can start off on your branch and work on suggestions. |
|
r? @jeremy |
|
@prathamesh-sonpatki no, I dont code. Feel free to help thanks. |
|
@homakov Thanks, I will work on Jeremy's suggestions. |
|
I have a branch locally, will get it wrapped in next few days. |
|
@prathamesh-sonpatki Did you look into this? |
|
Yes, I am working on it. |
|
Closing in favor of #23852 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's why by default it must include subdomains as it's much more common scenario. Very few websites intend to leave their blog.app.com working over http:// while having everything else encrypted.
Yes, many developers forget to add subdomains=true manually, believe me :)