ActiveRecord find_nth finder respects limit() #24124
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #23979.
Issue #23979 describes behavior where the ActiveRecord
first
andlast
would behave differently following alimit()
, and DHH's comment in #23598 (comment) pointed to thefirst
method being the one that was behaving incorrectly.Specifically,
limit(1).first(2)
would return a set of size 2 (incorrect), whilelimit(1).last(2)
would return a record set of size 1 (correct).This PR introduces a test suite to capture the interrelationships between
limit
and the finder methods (bothfirst(n)
as well assecond
,third
, and so on).It also adjusts those finder methods to make the test suite pass: making them respect the
limit
and making them consistent with the behavior of thelast
finders.