show correct command name in help of rails runner #24325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pixeltrix (@rails-bot has picked a reviewer for you, use r? to override) |
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| options = { environment: (ENV['RAILS_ENV'] || ENV['RACK_ENV'] || "development").dup } | |||
| code_or_file = nil | |||
|
|
|||
| command = 'bin/rails runner' | |||
| if ARGV.first.nil? | |||
There was a problem hiding this comment.
Nitpick but can you add a line break after this?
If use rails together with `spring`, `spring` is rewrite `$0` in the interior command name. Therefore, for `$0` correct command name does not appear, `$0` has been modified so that it does not use.
y-yagi
force-pushed
the
show_correct_command_name_in_help_of_rails_runner
branch
from
b6fc139
to
06cd7ab
Compare
|
Thanks! |
|
😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If you using spring, help of rails runner will show an incorrect command name.
springis rewrite$0in the interior command name.Therefore, for
$0correct command name does not appear, fixed so that it does not use$0.