Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't create new arrays when trying to compute non_empty_predicates for ast generation #24607

Merged
merged 1 commit into from
Apr 18, 2016
Merged

Don't create new arrays when trying to compute non_empty_predicates for ast generation #24607

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion activerecord/lib/active_record/relation/where_clause.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,9 @@ def predicates_with_wrapped_sql_literals
end
end

ARRAY_WITH_EMPTY_STRING = ['']
def non_empty_predicates
predicates - ['']
predicates - ARRAY_WITH_EMPTY_STRING
end

def wrap_sql_literal(node)
Expand Down