Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add doc for :type option of #create_join_table [ci skip] #24667

Merged
merged 1 commit into from
Apr 21, 2016
Merged

add doc for :type option of #create_join_table [ci skip] #24667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,8 @@ def create_table(table_name, comment: nil, **options)
# [<tt>:force</tt>]
# Set to true to drop the table before creating it.
# Defaults to false.
# [<tt>:type</tt>]
# The column type of primary key. Defaults to +:integer+.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@y-yagi I merged it fast. But the type is coming from column_options not as direct argument.

type = column_options.delete(:type) || :integer

right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted it for now #24668

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prathamesh-sonpatki
Oops, sorry. I was misunderstood 🙇

#
# Note that #create_join_table does not create any indices by default; you can use
# its block form to do so yourself:
Expand Down