Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to fix duplicate console logging in Rails 4-2-stable #25284

Merged
merged 2 commits into from Feb 22, 2017

Conversation

bmulvihill
Copy link

Summary

Backport to prevent duplicate logging to the console in Rails 4 branch
Based on this PR which fixed the issue in master:
#22933

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @arthurnn (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rails-bot
Copy link

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against 4-2-stable. Please double check that you specified the right target!

@schneems
Copy link
Member

schneems commented Jun 5, 2016

I wrote this commit on master. I'm fine with this being backported.

@grosser
Copy link
Contributor

grosser commented Feb 22, 2017

@schneems this can be closed now since I think nobody will merge that :(

@rafaelfranca rafaelfranca merged commit 9d2cd62 into rails:4-2-stable Feb 22, 2017
@rafaelfranca
Copy link
Member

😄

@jmgarnier
Copy link

I am curious, @bmulvihill Why didn't you also backport the fix on Rails::Server ?

image

Screenshot from https://github.com/rails/rails/pull/22933/files#diff-df74380653b76916147b7ad1f036fe41

Shall I give a try to my first PR after 10 years of Rails 😳 to backport it?

PS: Funny, wherever I look, I always end up crossing @grosser path 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants