Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.1.0.rc6] hello_w*rld.erb in ActionPack breaks git on Windows #2574

Closed
jhtwong opened this issue Aug 18, 2011 · 6 comments
Closed

[3.1.0.rc6] hello_w*rld.erb in ActionPack breaks git on Windows #2574

jhtwong opened this issue Aug 18, 2011 · 6 comments
Assignees

Comments

@jhtwong
Copy link
Contributor

jhtwong commented Aug 18, 2011

It looks like commit 09ad48f introduced actionpack/test/fixtures/test/hello_w*rld.erb which breaks git on Windows, where you can't create a file with an asterisk in the name, even with "reserved name" checking turned off (e.g. the UNC path trick shown here: http://support.microsoft.com/kb/315226)

@ghost ghost assigned josevalim Aug 18, 2011
@josevalim
Copy link
Contributor

Does window allow "{" "}" "," in the filename?

@jhtwong
Copy link
Contributor Author

jhtwong commented Aug 18, 2011

Yes, Windows allows braces "{" "}" and comma "," in filenames. Hopefully git on Windows can handle them too.

@cfis
Copy link

cfis commented Aug 23, 2011

Seeing this here also. What happens is:

Updating git://github.com/rails/rails.git
error: unable to create file actionpack/test/fixtures/test/hello_w*rld.erb (Invalid argument)
Checking out files: 100% (2210/2210), done.
fatal: Could not reset index file to revision '94a780356cd2ea6c7cb1ce75525596b28857870b'.
Git error: command git reset --hard 94a780356cd2ea6c7cb1ce75525596b28857870b in directory C:/MinGW/local/ruby/lib/ruby/gems/1.9.1/bundler/gems/rails-94a780356cd2 has failed.
If this error persists you could try removing the cache directory 'C:/MinGW/local/ruby/lib/ruby/gems/1.9.1/cache/bundler/git/rails-16a5e918a06649ffac24fd5873b875daf66212ad'

Windows does not allow the following characters in a filename:

/:*?"<>|

@CasualNetworks
Copy link

I also ran into this issue:

Fetching git://github.com/rails/rails.git
remote: Counting objects: 252147, done.
remote: Compressing objects: 100% (61807/61807), done.
remote: Total 252147 (delta 196079), reused 242749 (delta 187883)
Receiving objects: 100% (252147/252147), 33.70 MiB | 643 KiB/s, done.
Resolving deltas: 100% (196079/196079), done.
error: unable to create file actionpack/test/fixtures/test/hello_w*rld.erb (Invalid argument)
fatal: Could not reset index file to revision '68424fb1cf45acda3ad1daef30136f3bcd4f9f9d'.
Git error: command git reset --hard 68424fb1cf45acda3ad1daef30136f3bcd4f9f9d in directory C:/Ruby192/lib/ruby/gems/1.9.1/bundler/gems/rails-68424fb1cf45 has failed
If this error persists you could try removing the cache directory 'C:/Ruby192/lib/ruby/gems/1.9.1/cache/bundler/git/rails-16a5e918a06649ffac24fd5873b875daf66212ad'

@cfis
Copy link

cfis commented Aug 25, 2011

Could we get this fixed? Seems a bit draconian to totally break a platform for a test.

@CasualNetworks
Copy link

What do you need for this ticket to be included with in the Rails 3.1 release scope?

My concern is if this is not tagged for Rails 3.1, that their is a risk of Rails 3.1 not working/supporting on Windows hosts?

If you need me to fork and back out the commit 09ad48f, I can do that and submit a pull request.

guilleiguaran pushed a commit to guilleiguaran/rails that referenced this issue Sep 5, 2011
raybaxter pushed a commit to raybaxter/rails-1 that referenced this issue Sep 5, 2011
arunagw pushed a commit to arunagw/rails that referenced this issue Sep 5, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants