Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enum with alias_attribute #25998

Merged
merged 1 commit into from
Aug 6, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 6 additions & 5 deletions activerecord/lib/active_record/enum.rb
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,9 @@ def enum(definitions)
detect_enum_conflict!(name, name)
detect_enum_conflict!(name, "#{name}=")

decorate_attribute_type(name, :enum) do |subtype|
EnumType.new(name, enum_values, subtype)
attr = attribute_alias?(name) ? attribute_alias(name) : name
decorate_attribute_type(attr, :enum) do |subtype|
EnumType.new(attr, enum_values, subtype)
end

_enum_methods_module.module_eval do
Expand All @@ -184,15 +185,15 @@ def enum(definitions)

# def active?() status == 0 end
klass.send(:detect_enum_conflict!, name, "#{value_method_name}?")
define_method("#{value_method_name}?") { self[name] == value.to_s }
define_method("#{value_method_name}?") { self[attr] == value.to_s }

# def active!() update! status: :active end
klass.send(:detect_enum_conflict!, name, "#{value_method_name}!")
define_method("#{value_method_name}!") { update! name => value }
define_method("#{value_method_name}!") { update!(attr => value) }

# scope :active, -> { where status: 0 }
klass.send(:detect_enum_conflict!, name, value_method_name, true)
klass.scope value_method_name, -> { where(name => value) }
klass.scope value_method_name, -> { where(attr => value) }
end
end
defined_enums[name.to_s] = enum_values
Expand Down
16 changes: 16 additions & 0 deletions activerecord/test/cases/enum_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -393,6 +393,22 @@ def self.name; 'Book'; end
assert book2.single?
end

test "enum with alias_attribute" do
klass = Class.new(ActiveRecord::Base) do
self.table_name = "books"
alias_attribute :aliased_status, :status
enum aliased_status: [:proposed, :written, :published]
end

book = klass.proposed.create!
assert book.proposed?
assert_equal 'proposed', book.aliased_status

book = klass.find(book.id)
assert book.proposed?
assert_equal 'proposed', book.aliased_status
end

test "query state by predicate with prefix" do
assert @book.author_visibility_visible?
assert_not @book.author_visibility_invisible?
Expand Down