Remove unnecessary ordinal methods for collection association #26200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `CollectionProxy` inherits `Relation` therefore we can use its own methods rather than delegating to collection association.
|
r? @eileencodes (@rails-bot has picked a reviewer for you, use r? to override) |
| @@ -453,6 +409,12 @@ def null_scope? | |||
| owner.new_record? && !foreign_key_present? | |||
| end | |||
|
|
|||
| def find_from_target? | |||
There was a problem hiding this comment.
Did this method become public now? Does it need to be public?
There was a problem hiding this comment.
Yes, this method is called by collection proxy like null_scope?.
https://github.com/rails/rails/pull/26200/files#diff-bee622c17de67f292adf310f75288e25R1126
This was referenced May 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
CollectionProxyinheritsRelationtherefore we can useits own methods rather than delegating to collection association.