Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix case insensitive check for text column in pg #26208

Merged
merged 2 commits into from
Oct 11, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -770,11 +770,15 @@ def can_perform_case_insensitive_comparison_for?(column)
@case_insensitive_cache[column.sql_type] ||= begin
sql = <<-end_sql
SELECT exists(
SELECT * FROM pg_proc
WHERE proname = 'lower'
AND proargtypes = ARRAY[#{quote column.sql_type}::regtype]::oidvector
) OR exists(
SELECT * FROM pg_proc
INNER JOIN pg_cast
ON casttarget::text::oidvector = proargtypes
ON ARRAY[casttarget]::oidvector = proargtypes
WHERE proname = 'lower'
AND castsource = '#{column.sql_type}'::regtype::oid
AND castsource = #{quote column.sql_type}::regtype
)
end_sql
execute_and_clear(sql, "SCHEMA", []) do |result|
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
require "cases/helper"

class PostgresqlCaseInsensitiveTest < ActiveRecord::PostgreSQLTestCase
class Default < ActiveRecord::Base; end

def test_case_insensitiveness
connection = ActiveRecord::Base.connection
table = Default.arel_table

column = Default.columns_hash["char1"]
comparison = connection.case_insensitive_comparison table, :char1, column, nil
assert_match /lower/i, comparison.to_sql

column = Default.columns_hash["char2"]
comparison = connection.case_insensitive_comparison table, :char2, column, nil
assert_match /lower/i, comparison.to_sql

column = Default.columns_hash["char3"]
comparison = connection.case_insensitive_comparison table, :char3, column, nil
assert_match /lower/i, comparison.to_sql

column = Default.columns_hash["multiline_default"]
comparison = connection.case_insensitive_comparison table, :multiline_default, column, nil
assert_match /lower/i, comparison.to_sql
end
end