support - as an argument to rails runner
#26343
Conversation
|
r? @sgrif (@rails-bot has picked a reviewer for you, use r? to override) |
|
Would it make sense for us to just always read from stdin when stdin isn't a TTY? /cc @rafaelfranca |
|
@sgrif: I'd say no. I would assume it would be a normal use case to do something like:
|
|
I'm actually wondering if this is just a bug in Ruby that should be handled upstream. It strikes me as odd that |
|
Yeah, I thought it was odd. But with this, it's also portable to Windows |
|
I think it's reasonable. Can you fix the code climate issues. Can you also give some example of another application that uses |
ccutrer
force-pushed
the
runner_from_stdin
branch
from
6a2a28a
to
8c2b815
Compare
|
commit updated; it should pass code climate this time, and I think that's what you meant by an improved example |
|
Another useful case is running rails scripts inside a docker container: copying the file inside the container is a gymnastic you probably want to avoid, VS @sgrif @ccutrer it would be cool to have this included in a future version of rails. Can I (or others) help to make this happen? |
| @@ -30,6 +30,9 @@ | |||
| opts.separator "" | |||
| opts.separator " rails runner path/to/filename.rb" | |||
| opts.separator " This runs the Ruby file located at `path/to/filename.rb` after loading the app" | |||
| opts.separator "" | |||
| opts.separator " cat local_script.rb | ssh myserver '/var/www/myapp/bin/rails runner -'" | |||
There was a problem hiding this comment.
This buries the example quite a bit. How about just rails runner -?
ccutrer
force-pushed
the
runner_from_stdin
branch
from
8c2b815
to
2350ee8
Compare
in Rails 4.0, you could use `/dev/stdin` on both Linux and Mac, but with the switch to Kernel.load in Rails 4.1, this broke on Linux (you get a LoadError). Instead, explicitly detect `-` as meaning stdin, then read from stdin explicitly, instead of performing file gymnastics. This should now work on any platform uniformly. Passing a script via stdin is useful when you're sshing to a server, and the script you want to run is stored locally. You could theoretically pass the entire script on the command line, but in reality you'll run into problems with the command being too long.
ccutrer
force-pushed
the
runner_from_stdin
branch
from
2350ee8
to
ed44b14
Compare
|
Rebased with conflicts resolved, and simplified the usage example. |
Summary
in Rails 4.0, you could use
/dev/stdinon both Linux and Mac, but withthe switch to Kernel.load in Rails 4.1, this broke on Linux (you get
a LoadError). Instead, explicitly detect
-as meaning stdin, thenread from stdin explicitly, instead of performing file gymnastics. This
should now work on any platform uniformly.
Other Information
Passing a script via stdin is useful when you're sshing to a server,
and the script you want to run is stored locally. You could theoretically
pass the entire script on the command line, but in reality you'll run
into problems with the command being too long.