Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the use of listen's 3.1.x branch. #26695

Merged
merged 1 commit into from Oct 3, 2016
Merged

Conversation

MentalPower
Copy link
Contributor

Summary

We have a need to use the newer versions of the listen gem and the version pinning in rails & specifically railties is preventing this. When the initial evented monitor feature was written, the latest version of listen was the 3.0.x series. Since then the listen project has moved on to the 3.1.x series. This patch corrects that version pinning by expanding its range to include the 3.1.x branch.

Other Information

The bundle exec rake test command was run for railties & activesupport to make sure that there was no regression. CHANGELOG, Gemfile.lock and documentation were also updated.

When the initial evented monitor feature was written, the latest version of listen
was the 3.0.x series. Since then the listen project has moved on to the 3.1.x series.
This patch allows the use of the new versions.
@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@eileencodes eileencodes merged commit 60cc506 into rails:master Oct 3, 2016
@eileencodes
Copy link
Member

Thanks @MentalPower!

@eileencodes
Copy link
Member

Actually - I just noticed that a bunch of other stuff got updated. Do all those things depend on the listen update?

@MentalPower
Copy link
Contributor Author

Nope, just the listen block. I updated the entire Gemfile.lock since that was the suggestion from the contribution doc. Is there a way to do a restricted bundle update?

@eileencodes
Copy link
Member

I just checked and you're right the contributing doc says that. This is all minor version stuff and the tests passed so I think it's ok. I usually run bundle update --source gem_name where gem_name would be listen to restrict updates.

@MentalPower
Copy link
Contributor Author

Good to know, I'll do that for the backport request. Thanks @eileencodes.

MentalPower added a commit to MentalPower/rails that referenced this pull request Oct 5, 2016
When the initial evented monitor feature was written, the latest version of listen
was the 3.0.x series. Since then the listen project has moved on to the 3.1.x series.
This patch allows the use of the new versions.

This is the 5.0 branch version of rails#26695
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants