Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mask forking filesystem event on JRuby. #26830

Merged
merged 1 commit into from
Oct 20, 2016
Merged

Mask forking filesystem event on JRuby. #26830

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions activesupport/test/evented_file_update_checker_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ def rm_f(files)
end

test 'notifies forked processes' do
skip if defined?(JRUBY_VERSION)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a helper method jruby_skip for skipping tests on JRuby.

We can just that here. jruby_skip "Forking not available on JRuby" 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it got merged. Want another PR or can someone just patch up that line for me? :-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rafael changed it in merge commit 👍


FileUtils.touch(tmpfiles)

checker = new_checker(tmpfiles) { }
Expand Down