New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Yarn the default, drop default vendor/asset directories #27300

Merged
merged 1 commit into from Dec 8, 2016

Conversation

Projects
None yet
8 participants
@dhh
Member

dhh commented Dec 8, 2016

Yarn is good. Yarn works.

@maclover7 maclover7 added the railties label Dec 8, 2016

@airhorns

This comment has been minimized.

Show comment
Hide comment
@airhorns

airhorns Dec 8, 2016

Contributor

FWIW we had some issues with yarn at Shopify where they shipped a few fully broken releases and pulled production versions in the last couple weeks. We had to pin the version at 0.16 and are carefully testing the newest one to make sure it doesn't break on us before rolling it out to all developers. 0.17 perhaps was just an anomaly, but it might make sense to wait a month or two to let it stabilize a bit before endorsing it for the whole Rails community.

Waiting two more months will double the time it's been in the wild and it doesn't seem like there is much urgency.

Contributor

airhorns commented Dec 8, 2016

FWIW we had some issues with yarn at Shopify where they shipped a few fully broken releases and pulled production versions in the last couple weeks. We had to pin the version at 0.16 and are carefully testing the newest one to make sure it doesn't break on us before rolling it out to all developers. 0.17 perhaps was just an anomaly, but it might make sense to wait a month or two to let it stabilize a bit before endorsing it for the whole Rails community.

Waiting two more months will double the time it's been in the wild and it doesn't seem like there is much urgency.

@guilleiguaran

This comment has been minimized.

Show comment
Hide comment
@guilleiguaran

guilleiguaran Dec 8, 2016

Member

@airhorns I think we will have plenty time to test this between now and the first betas of Rails 5.1, I don't think we have a ETA for 5.1 beta yet but I'm pretty sure it won't be released in the next 3 or 4 months.

Member

guilleiguaran commented Dec 8, 2016

@airhorns I think we will have plenty time to test this between now and the first betas of Rails 5.1, I don't think we have a ETA for 5.1 beta yet but I'm pretty sure it won't be released in the next 3 or 4 months.

@chirag7jain

This comment has been minimized.

Show comment
Hide comment
@chirag7jain

chirag7jain Dec 8, 2016

if configuration bit could be in rails app config itself and assets precompile could indirectly run yarn that would be great

chirag7jain commented Dec 8, 2016

if configuration bit could be in rails app config itself and assets precompile could indirectly run yarn that would be great

@bogdan

This comment has been minimized.

Show comment
Hide comment
@bogdan

bogdan Dec 8, 2016

Contributor

Why is it ./vendor/package.json but not ./package.json? It looks like the thing of the same kind as Gemfile and should probably be placed at root too.

Contributor

bogdan commented Dec 8, 2016

Why is it ./vendor/package.json but not ./package.json? It looks like the thing of the same kind as Gemfile and should probably be placed at root too.

@nateberkopec

This comment has been minimized.

Show comment
Hide comment
@nateberkopec

nateberkopec Dec 8, 2016

Contributor

@bogdan That was hashed out on a separate issue/thread. @dhh mentioned he thought Gemfile could eventually be moved to /vendor as well.

Contributor

nateberkopec commented Dec 8, 2016

@bogdan That was hashed out on a separate issue/thread. @dhh mentioned he thought Gemfile could eventually be moved to /vendor as well.

@dhh dhh merged commit 0d20530 into master Dec 8, 2016

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
codeclimate no new or fixed issues
Details

@dhh dhh deleted the yarn-by-default branch Dec 8, 2016

@rafaelfranca

This comment has been minimized.

Show comment
Hide comment
@rafaelfranca
Member

rafaelfranca commented Dec 8, 2016

👏

wtholt added a commit to sparc-request/sparc-request that referenced this pull request Feb 23, 2018

wth - Use Yarn to manage our front-end assets
Yarn is now a part of the Rails default stack. We should use this package manager for our front-end assets like Bootstrap, jQuery, etc.

This is a first step, all new js/css libraries should be added via Yarn.

https://yarnpkg.com/en/
rails/rails#27300
http://weblog.rubyonrails.org/2016/12/10/this-week-in-rails-yarn-webpack-bigint-pks-and-more/
http://nithinbekal.com/posts/yarn-rails/

[#147836807]

Story - https://www.pivotaltracker.com/story/show/147836807

wtholt added a commit to sparc-request/sparc-request that referenced this pull request Feb 23, 2018

wth - Use Yarn to manage our front-end assets
Yarn is now a part of the Rails default stack. We should use this package manager for our front-end assets like Bootstrap, jQuery, etc.

This is a first step, all new js/css libraries should be added via Yarn.

https://yarnpkg.com/en/
rails/rails#27300
http://weblog.rubyonrails.org/2016/12/10/this-week-in-rails-yarn-webpack-bigint-pks-and-more/
http://nithinbekal.com/posts/yarn-rails/

[#147836807]

Story - https://www.pivotaltracker.com/story/show/147836807
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment