Make Yarn the default, drop default vendor/asset directories #27300

Merged
merged 1 commit into from Dec 8, 2016

Projects

None yet

8 participants

@dhh
Member
dhh commented Dec 8, 2016

Yarn is good. Yarn works.

@dhh dhh Make Yarn the default, drop default vendor/asset directories
41ea0bf
@maclover7 maclover7 added the railties label Dec 8, 2016
@airhorns
Contributor
airhorns commented Dec 8, 2016 edited

FWIW we had some issues with yarn at Shopify where they shipped a few fully broken releases and pulled production versions in the last couple weeks. We had to pin the version at 0.16 and are carefully testing the newest one to make sure it doesn't break on us before rolling it out to all developers. 0.17 perhaps was just an anomaly, but it might make sense to wait a month or two to let it stabilize a bit before endorsing it for the whole Rails community.

Waiting two more months will double the time it's been in the wild and it doesn't seem like there is much urgency.

@guilleiguaran
Member
guilleiguaran commented Dec 8, 2016 edited

@airhorns I think we will have plenty time to test this between now and the first betas of Rails 5.1, I don't think we have a ETA for 5.1 beta yet but I'm pretty sure it won't be released in the next 3 or 4 months.

@chirag7jain

if configuration bit could be in rails app config itself and assets precompile could indirectly run yarn that would be great

@bogdan
Contributor
bogdan commented Dec 8, 2016

Why is it ./vendor/package.json but not ./package.json? It looks like the thing of the same kind as Gemfile and should probably be placed at root too.

@nateberkopec
Contributor

@bogdan That was hashed out on a separate issue/thread. @dhh mentioned he thought Gemfile could eventually be moved to /vendor as well.

@dhh dhh merged commit 0d20530 into master Dec 8, 2016

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
codeclimate no new or fixed issues
Details
@dhh dhh deleted the yarn-by-default branch Dec 8, 2016
@rafaelfranca
Member

👏

@m5o m5o referenced this pull request in ytbryan/vuejs Dec 11, 2016
Closed

vuejs integration with rails/webpacker #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment