Fix reflection.association_primary_key for has_many association
#27609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamipo
force-pushed
the
fix_association_primary_key
branch
from
0ecbcd4
to
4a04fda
Compare
kamipo
force-pushed
the
fix_association_primary_key
branch
from
4a04fda
to
fcb3504
Compare
|
@tenderlove Could you review this? |
kamipo
force-pushed
the
fix_association_primary_key
branch
from
fcb3504
to
09e8cfc
Compare
It is incorrect to treat `options[:primary_key]` as `association_primary_key` if `has_many` associations because the `:primary_key` means the column on the owner record, not on the association record. It will break `ids_reader` and `ids_writer`. ```ruby people(:david).essay_ids # => ActiveRecord::StatementInvalid: Mysql2::Error: Unknown column 'essays.first_name' in 'field list': SELECT `essays`.first_name FROM `essays` WHERE `essays`.`writer_id` = 'David' ``` Fixes rails#14439.
kamipo
force-pushed
the
fix_association_primary_key
branch
from
09e8cfc
to
b23e869
Compare
rafaelfranca
added a commit
that referenced
this pull request
Aug 14, 2017
Fix `reflection.association_primary_key` for `has_many` association
rafaelfranca
added a commit
that referenced
this pull request
Aug 14, 2017
Fix `reflection.association_primary_key` for `has_many` association
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is incorrect to treat
options[:primary_key]asassociation_primary_keyifhas_manyassociations because the:primary_keymeans the column on the owner record, not on theassociation record. It will break
ids_readerandids_writer.Fixes #14439.