fix method name in Renderer doc [ci skip]
#27656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @senny (@rails-bot has picked a reviewer for you, use r? to override) |
| @@ -60,7 +60,7 @@ def with_defaults(defaults) | |||
| end | |||
|
|
|||
| # Accepts a custom Rack environment to render templates in. | |||
| # It will be merged with ActionController::Renderer.defaults | |||
| # It will be merged with +ActionController::Renderer::DEFAULTS+ | |||
There was a problem hiding this comment.
defaults is an attr_reader so ActionController::Renderer.defaults will work.
There was a problem hiding this comment.
Ah I see what is happening, 👍
There was a problem hiding this comment.
I wonder though this statement is useful or not?
There was a problem hiding this comment.
May be
It will be merged with the default Rack environment defined by
ActionController::Renderer::DEFAULTS.
?
There was a problem hiding this comment.
Looks good. I updated. Thanks!
`ActionController::Renderer.defaults` was removed in 2db7304
y-yagi
force-pushed
the
fix_method_name_in_renderer_doc
branch
from
f48c765
to
67471a2
Compare
|
Awesome, thanks 👍 |
kaspth
pushed a commit
that referenced
this pull request
Jan 14, 2017
fix method name in `Renderer` doc [ci skip]
|
Sure! On 5-0-stable in f1fe92e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActionController::Renderer.defaultswas removed in 2db7304