Delegate to_sentence and to_fomatted_s to records
#27904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @matthewd (@rails-bot has picked a reviewer for you, use r? to override) |
simi
reviewed
Feb 4, 2017
| @@ -37,7 +37,7 @@ def inherited(child_class) | |||
| # for each different klass, and the delegations are compiled into that subclass only. | |||
|
|
|||
| delegate :to_xml, :encode_with, :length, :collect, :map, :each, :all?, :include?, :to_ary, :join, | |||
| :[], :&, :|, :+, :-, :sample, :reverse, :compact, :in_groups, :in_groups_of, | |||
| :[], :&, :|, :+, :-, :sample, :reverse, :compact, :in_groups, :in_groups_of, :to_sentence, :to_formatted_s, :to_xml, | |||
kenta-s
force-pushed
the
add-methods-back-to-array-delegation-from-ar-relation
branch
2 times, most recently
from
bc7cf95
to
5aa368b
Compare
|
@simi Thank you. And I mistakenly added |
kenta-s
changed the title
to_sentence, to_fomatted_s and to_xml to recordsto_sentence and to_fomatted_s to records
|
@kenta-s Can you add a test to confirm the new behavior? Thanks! |
|
Should be enough to add new delegations to this array in test suite. |
kenta-s
force-pushed
the
add-methods-back-to-array-delegation-from-ar-relation
branch
from
5aa368b
to
5d50962
Compare
|
done :) |
eileencodes
added a commit
that referenced
this pull request
Feb 10, 2017
…gation-from-ar-relation Delegate `to_sentence` and `to_fomatted_s` to `records`
|
Backported to 5-0-stable in 28a1bdd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #27901