Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use Arel.star when ignored_columns #27918

Closed
wants to merge 2 commits into from
Closed

Do not use Arel.star when ignored_columns #27918

wants to merge 2 commits into from

Commits on Feb 20, 2017

  1. Do not use Arel.star when ignored_columns 

    If there are any ignored columns, we will now list out all columns we
want to be returned from the database.

Includes a regression test.

Re: the test I had to change, it should have never been passing in the
first place, due to the ignored `first_name` column on `Developer.
    @maclover7
    maclover7 committed Feb 20, 2017
    Configuration menu
    Copy the full SHA
    8717d9d View commit details
    Browse the repository at this point in the history

  2. Change tests to use models which don't ignore any columns

    @maclover7
    maclover7 committed Feb 20, 2017
    Configuration menu
    Copy the full SHA
    63dead8 View commit details
    Browse the repository at this point in the history