Add methods [days, weeks, months, years]_between #27966
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`#days_between` returns the number of days to given date, default to +Date.current+. `#weeks_between` returns the number of weeks to given date, default to +Date.current+. `#months_between` returns the number of months to given date, default to +Date.current+. `#years_between` returns the number of years to given date, default to +Date.current+.
|
(@rails-bot has picked a reviewer for you, use r? to override) |
|
Thank you so much for the pull request but we avoid adding new methods to active record core extension unless it is useful for the framework or many web applications. |
|
how to know does it useful for many web application? |
|
I agree with @rafaelfranca. Please keep in mind that if it's really common enough for your frequent use, it still needn't be a part of ActiveSupport but seems like a great idea for a simple gem. (I just found https://github.com/abhidsm/time_diff as such an example) |
|
@chrisarcand i agree, thanks for explanation! |
bogdanvlviv
added a commit
to bogdanvlviv/general_time
that referenced
this pull request
Feb 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it might be useful, so i decided to make this PR.
Added methods:
#days_betweenreturns the number of days to given date, default to +Date.current+.
#weeks_betweenreturns the number of weeks to given date, default to +Date.current+.
#months_betweenreturns the number of months to given date, default to +Date.current+.
#years_betweenreturns the number of years to given date, default to +Date.current+.
Your thoughts guys?