Add first draft of release notes for Rails 5.1 🎉 #28096
Conversation
|
cc @kaspth @matthewd @rafaelfranca Just added skeleton for now. Should we get this in and then I will work on each of the components. |
| Major Features | ||
| -------------- | ||
|
|
||
| ### Yarn Support |
There was a problem hiding this comment.
Need a ### Webpack support header as well
There was a problem hiding this comment.
And one for the jQuery item too
There was a problem hiding this comment.
@kaspth Sure, one for 3-level database.yml as well
|
Even better if we can sample some starting descriptions from rails/weblog#97 |
|
@kaspth Sure, I will add it, I thought we wanted to merge this last night :) |
|
|
||
| -------------------------------------------------------------------------------- | ||
|
|
||
| Upgrading to Rails 5.1 |
There was a problem hiding this comment.
We need to add info about the HashWithIndifferentAccess deprecation. This is already mentioned on the upgrading page
I believe it should be mentioned and guided here as-well, although it's only a deprecation note for future 5.2-release.
There was a problem hiding this comment.
@frederikspang I haven't started work on upgrading guide but I will keep a note of this point and add it. Thanks!
prathamesh-sonpatki
force-pushed
the
5-1-release-notes-first-draft
branch
2 times, most recently
from
a775f64
to
5896e2d
Compare
guides/source/5_1_release_notes.md
Outdated
| mail subject: "#{@inviter.name.familiar} added you to a project in Basecamp (#{@account.name})" | ||
| end | ||
|
|
||
| InvitationsMailer.with(inviter: person_a, invitee: person_b).account_invitation.deliver_later |
There was a problem hiding this comment.
@prathamesh-sonpatki looks like some whitespace is off in most of these code examples
guides/source/5_1_release_notes.md
Outdated
| @summarizer = ProjectInvitationSummarizer.new(@project.bucket) | ||
|
|
||
| mail subject: "#{@inviter.name.familiar} added you to a project in Basecamp (#{@account.name})" | ||
| end |
prathamesh-sonpatki
force-pushed
the
5-1-release-notes-first-draft
branch
from
5896e2d
to
b4dbe8c
Compare
|
@kaspth Please review. |
| ``` ruby | ||
| resource :basket | ||
|
|
||
| resolve(class: "Basket") { [:basket] } |
No description provided.