Soft-deprecate the HashWithIndifferentAccess constant
#28157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since using a `ActiveSupport::Deprecation::DeprecatedConstantProxy` would prevent people from inheriting this class and extending it from the `ActiveSupport::HashWithIndifferentAccess` one would break the ancestors chain, that's the best option we have here.
This ensures that if we try to hard-deprecate it again in the future, we won't break these behaviors.
matthewd
added a commit
that referenced
this pull request
Feb 25, 2017
Soft-deprecate the `HashWithIndifferentAccess` constant
et
reviewed
Feb 25, 2017
| @@ -1,3 +1,9 @@ | |||
| * Soft-deprecated the top-level `HashWithIndifferentAcces` constant. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
That's just a second take on #27925. This version just softly deprecates the top-level
HashWithIndifferentAccessconstant rather than trying to display a deprecation message since this constant and theActiveSupport-scoped one are exactly the same which means that changing one inevitably changes the other.PS : Even though it's not yet posted, I took the liberty to add the link to the 5.1 release notes in the upgrade guides to avoid missing it writing the other steps of the upgrade process.
Have a nice day ! :-)