Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update guide to reflect browser compatibility for HTTP verbs #28550

Conversation

rachel-carvalho
Copy link
Contributor

Summary

This updates the security guide to reflect how most browsers now do support all restful HTTP verbs.

Other Information

I was reading up on CSRF because I have an API controller that didn't pass brakeman validation for not having protect_from_forgery.

I ended up on Rails Guides for how to handle CSRF and it says this (my emphasis):

The HTTP protocol basically provides two main types of requests - GET and POST (and more, but they are not supported by most browsers)

Which I thought weird because it seemed to me that most browsers do currently support all RESTful methods. And MDN confirmed what I thought.

So I decided to update the text to say that Some legacy web browsers don't support the other methods.

I appreciate any improvements on the wording, especially because I'm not a native English speaker.

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@maclover7
Copy link
Contributor

👍 Thank you for your contribution!

❤️ 💚 💙 💛 💜

@maclover7 maclover7 merged commit 2f3e12b into rails:master Mar 23, 2017
@rachel-carvalho
Copy link
Contributor Author

Wow this was the fastest Pull Request resolution I've ever seen! Thank you and keep up the great job guys ❤️❤️❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants