Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure dumps with no migrations run #28672

Closed
wants to merge 3 commits into from
Closed

Structure dumps with no migrations run #28672

wants to merge 3 commits into from

Conversation

afdev82
Copy link

@afdev82 afdev82 commented Apr 5, 2017

See #26438.
I was not able to submit a pull request to the original branch.

Lachlan Sylvester and others added 3 commits September 12, 2016 09:44
The sql that would be generated would be invalid if there are no versions and multi insert is supported
@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@kamipo
Copy link
Member

kamipo commented Aug 16, 2017

Closing in favor of #29462.

@kamipo kamipo closed this Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants