Fix a problem when re-defining has_many :through associations #29547
Conversation
This is an attempt to fix this issue: #29123 When calling a ‘has_many :through’ association we check if the source association is defined after the has_many :through. If it is, we throw a HasManyThroughOrderError. (See f8ab3ae) However, this error was being erroneously thrown in cases when the has_many :through overrides another association of the same name.
|
Thanks for the PR @tuzz What is the use case for re-defining an already defined association? I think that would cause unexpected behavior and be confusing to app developers. That seems more like an app bug than a Rails bug. |
|
@eileencodes: I don't think there is a use-case for re-defining an association, but given method overriding in Ruby is fairly common, I think it's reasonable to assume people will do it. In this case, a seemingly unrelated error is being thrown when this happens, which misleads people and sends them down a rabbit-hole of digging inside Rails to understand the problem. Perhaps it would be better to explicitly guard against re-defining associations. I'm not sure. What do you think? |
|
We don't want people to redefine the same association. It make no sense. Even ruby give warnings about redefining the same method. Let's disallow association override, instead of allowing it again. |
|
Ok, will look into that instead. |
This is an attempt to fix this issue: #29123
When calling a
has_many :throughassociation wecheck if the source association is defined after
the
has_many :through. If it is, we throw aHasManyThroughOrderError.(See: f8ab3ae)
However, this error was being erroneously thrown
in cases when the
has_many :throughoverridesanother association of the same name.