Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken Modulo operation on Duration objects #29606

Closed
wants to merge 1 commit into from
Closed

Fix broken Modulo operation on Duration objects #29606

wants to merge 1 commit into from

Conversation

Sayanc93
Copy link
Contributor

@Sayanc93 Sayanc93 commented Jun 28, 2017 •
edited

Fixes modulo operation on Duration objects and returns the result in seconds. Addresses issue #29603
Thanks!

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@Sayanc93 Sayanc93 force-pushed the fix-broken-modulo-operation-on-duration branch 2 times, most recently from 363a508 to d265bad Compare June 28, 2017 15:49
@rafaelfranca rafaelfranca assigned pixeltrix and unassigned schneems Jun 28, 2017
@rafaelfranca rafaelfranca added this to the 5.1.3 milestone Jun 28, 2017
@Sayanc93 Sayanc93 force-pushed the fix-broken-modulo-operation-on-duration branch from d265bad to 2916183 Compare June 28, 2017 18:25
sgrif
sgrif reviewed Jul 18, 2017
View reviewed changes
activesupport/CHANGELOG.md Outdated
@@ -1,3 +1,19 @@
* Fix broken Module operation on Duration objects
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Module/modulo

Copy link
Contributor Author

@Sayanc93 Sayanc93 Jul 18, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sgrif Thanks for the review! Fixed it and resolved conflicts on this branch

@Sayanc93 Sayanc93 force-pushed the fix-broken-modulo-operation-on-duration branch from ee0cc77 to 80db42c Compare July 18, 2017 19:21
@meinac meinac mentioned this pull request Jul 25, 2017
Closed
@Sayanc93 Sayanc93 force-pushed the fix-broken-modulo-operation-on-duration branch 2 times, most recently from 5ca1731 to 3434692 Compare July 25, 2017 23:43
@rafaelfranca
Copy link
Member

Closed by #29971

@rafaelfranca
Copy link
Member

Oops, wrong one

@rafaelfranca rafaelfranca reopened this Jul 27, 2017
@rafaelfranca
Copy link
Member

@pixeltrix could you also take a look on this?

@Sayanc93
Fix broken Modulo operation on Duration objects.
d2d5467 
Modulo operation on Scalar and Numeric values will now return new Duration objects in seconds
@Sayanc93 Sayanc93 force-pushed the fix-broken-modulo-operation-on-duration branch from 3434692 to d2d5467 Compare July 28, 2017 01:35
@pixeltrix
Copy link
Contributor

Edited and merged manually in a54e13b

@pixeltrix pixeltrix closed this Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgrif sgrif sgrif left review comments

Assignees

@pixeltrix pixeltrix

Labels
activesupport
Projects
None yet
Milestone
5.1.3
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Sayanc93 @rails-bot @rafaelfranca @pixeltrix @sgrif @schneems