Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Rails upgrade guide on ActionView::Helpers::RecordTagHelper #29884

Merged
merged 2 commits into from Jul 21, 2017

Conversation

padi
Copy link
Contributor

@padi padi commented Jul 21, 2017

Summary

Adds documentation for removed AV#content_tag_for and AV#div_for for completion.

Other details

I've also added a :nodoc: for the following methods (since I've accidentally ran into them by using Rdoc) and thought that they still existed as available methods for Rails 5.

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @sgrif (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@padi
Copy link
Contributor Author

padi commented Jul 21, 2017

Seems like the build failure has no relation to the current changes. It shouldn't affect any legitimate test since the changes just involve a documentation and a ruby comment. Didn't use [ci skip] though since I'm still technically modifying a ruby file.

@rafaelfranca rafaelfranca merged commit 81d7b98 into rails:master Jul 21, 2017
rafaelfranca added a commit that referenced this pull request Jul 21, 2017
Updates Rails upgrade guide on `ActionView::Helpers::RecordTagHelper`
@padi padi deleted the update_rails_5_upgrade_guide branch July 22, 2017 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants